-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtualenv 20.11.0 broke our pre-commit checks #2257
Labels
Comments
As pre-commit/pre-commit#2178 (comment) details the culprit here is pip and setuptools, virtualenv just makes easier that bug to manifest. There's nothing to be done on our end though. |
Thank you! |
https://pypi.org/project/virtualenv/20.11.1/ now ships setuptools 60.1.1 with the fix |
dhalperi
added a commit
to dhalperi/pybatfish
that referenced
this issue
Dec 30, 2021
Per pypa/virtualenv#2257, new version has been released.
dhalperi
added a commit
to batfish/pybatfish
that referenced
this issue
Dec 30, 2021
Per pypa/virtualenv#2257, new version has been released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
After overnight upgrade of virtualenv to 20.11.0, our precommit checks started failing with:
Environment
Provide at least:
pip list
of the host python wherevirtualenv
is installed:Investigation
Last succeeding build (public): https://buildkite.com/batfish/pybatfish-pre-commit/builds/27313#bbf21871-a3c6-44e6-b63b-f797e3c7de1f
Next run, first failing build (public): https://buildkite.com/batfish/pybatfish-pre-commit/builds/27314#475992ad-c90a-4457-ad74-1b94a0f78762
The only difference appears to be the upgrade to virtualenv-20.11.0 and the correspond loss of
backports.entry-points-selectable
.It has something to do with
isort
; I've tried both5.8.0
(as in the existing pre-commit file) and the latest5.10.1
release. Disablingisort
check inpre-commit
makes the build pass. batfish/pybatfish#805The text was updated successfully, but these errors were encountered: