Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --download option #2262

Merged
merged 1 commit into from
Dec 31, 2021
Merged

fix: --download option #2262

merged 1 commit into from
Dec 31, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Dec 30, 2021

Fixes #2120

Without those changes, downloads were only attempted for pinned versions.
When the --download option is used:

  • Always trigger a download when using bundle, don't even look at what is embedded / updated wheels.
  • Never trigger a download when using embed, only use the embedded version.
  • When a pinned version is used, start by looking if it matches embedded / updated wheels and fallback to to trigger a download if not found.

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@gaborbernat gaborbernat merged commit 61c065b into pypa:main Dec 31, 2021
@mayeut mayeut deleted the fix-download branch December 31, 2021 09:07
@gaborbernat
Copy link
Contributor

The fix now has been released via https://virtualenv.pypa.io/en/latest/changelog.html#v20-12-0-2021-12-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--download flag doesn't work
2 participants