Fixes the regexp to make it match the filenames produced by setuptools_scm

[KOLANICH]

No description provided.

[benoit-pierre]

Why not use the same one as pip?

[codecov]

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #269   +/-   ##
=======================================
  Coverage   59.49%   59.49%           
=======================================
  Files          12       12           
  Lines         827      827           
=======================================
  Hits          492      492           
  Misses        335      335

Impacted Files	Coverage Δ
wheel/wheelfile.py	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8006c9...6a79cbb. Read the comment docs.

[KOLANICH]

Why not use the same one as pip?

It is too broad so it was replaced here in c84867f breaking compatibility. IMHO it makes no sense to check wheel filename at all.

[agronholm]

What standard includes a commit hash in the wheel file name?

[agronholm]

FWIW, fixing was never blocked me making code changes, but getting a definitive answer from @dholth regarding the interpretation of PEP 427.

[KOLANICH]

What standard includes a commit hash in the wheel file name?

Not standard, but usage of pypa/setuptools_scm causes this kind of filenames to be produced. It is strange to see that pypa/wheel broken compatibility to pypa/setuptools_scm. This made some packages non-installable from git. I insist on fixing compatibility as soon as possible, since this breaks packages, especially my packages, and only then standardizing it. Or non-standardizing and taking measures to prevent this part from appearing in filename. I like the first variant better.

[agronholm]

We have an accepted standard saying that any character not matching [\w\d.] should be replaced by an underscore. I will fix this by making the regex even more permissible until we get a more definitive answer from the person who wrote the PEP.

[agronholm]

I made my own changes to the regex already so I'm closing this one.

[dholth]

That part of the spec is probably a mistake where it says "all components of the filename..." The package name needs to be so processed to match setuptools/pkg_resources, and we need to replace dashes to be able to parse the filename, but weird versions should be allowed by wheel itself. How does setuptools or pkg_resources transform version numbers?

On Thu, Oct 18, 2018, at 4:03 AM, Alex Grönholm wrote: I made my own changes to the regex already so I'm closing this one.> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[1], or mute the thread[2].

Links: 1. #269 (comment) 2. https://github.com/notifications/unsubscribe-auth/AAMsknEqiGmp8xc7Zyk071DhoxXvAIJeks5umDXBgaJpZM4XlgTh