feat: mathjax rendering #12062
Merged
feat: mathjax rendering #12062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time, load from CDN. As the main script loads other files from a shared CDN, scope the path they are allowed to as deeply as possible, which prevents anything else from being loaded outside that path. Combined with the resource integrity checks, and the content security policy updates, nothing else should be able to be loaded from the CDN. Signed-off-by: Mike Fiedler <[email protected]>
di
approved these changes
Aug 11, 2022
SamirPS
pushed a commit
to SamirPS/warehouse
that referenced
this pull request
Aug 30, 2022
This time, load from CDN. As the main script loads other files from a shared CDN, scope the path they are allowed to as deeply as possible, which prevents anything else from being loaded outside that path. Combined with the resource integrity checks, and the content security policy updates, nothing else should be able to be loaded from the CDN. Signed-off-by: Mike Fiedler <[email protected]> Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt in #12028, reverted in #12040 due to errors observed with cache busting, which didn't really work for resources in the static pipeline that need to call other resources. we'd have to modify the vendored code during the static build phase, which seemed even more complex.
This time, load from CDN.
As the main script loads other files from a shared CDN, scope the path they are allowed to as deeply as possible, which prevents anything else from being loaded outside that path.
Combined with the resource integrity checks, and the content security policy updates, nothing else should be able to be loaded from the CDN.
Signed-off-by: Mike Fiedler [email protected]