Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to hide user avatar #12285

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Add functionality to hide user avatar #12285

merged 1 commit into from
Sep 28, 2022

Conversation

di
Copy link
Member

@di di commented Sep 28, 2022

Since Gravatar seems to be completely unresponsive to moderation requests, and since this is 'user-published content' on PyPI that we don't have any control over, this PR gives admins the ability to hide a user's avatar on their profile.

@di di requested a review from a team as a code owner September 28, 2022 16:23
op.add_column(
"users",
sa.Column(
"hide_avatar", sa.Boolean(), server_default=sa.text("false"), nullable=False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If intuition serves me, the server_default will allow this migration to be fast, regardless of the nullable=False, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, yes.

@di di merged commit 15a547a into pypi:main Sep 28, 2022
@di di deleted the hide-user-avatar branch September 28, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants