-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the invalid-publisher
err msg more informative
#13941
Conversation
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyPI admins are the ultimate arbiters here, but I'm personally a -1 on the changes to the error messages here: I think they introduce more ambiguity than they resolve, unfortunately.
IMO a workable solution here would be to add another bulletpoint to the troubleshooting docs explicitly mentioning that any environment configured on PyPI needs to match the CI job's environment, and then include the troubleshooting URL in the error render on the gh-action-pypi-publish
side.
In other words: IMO this change should be docs-only, and should be accompanied by a separate PR to the gh-action-pypi-publish
action that updates the error message to include a link to the troubleshooting docs.
Signed-off-by: Keming <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
invalid-publisher
: valid token, but no corresponding publisher pypa/gh-action-pypi-publish#138 (comment)