Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply "Store attestations for PEP740 (#16302)" (#16545) #16546

Merged
merged 39 commits into from
Sep 3, 2024
Merged

Reapply "Store attestations for PEP740 (#16302)" (#16545) #16546

merged 39 commits into from
Sep 3, 2024

Commits on Aug 21, 2024

  1. Reapply "Store attestations for PEP740 (pypi#16302)" (pypi#16545) 

    This reverts commit da7e1ed.
    @woodruffw
    woodruffw committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d8f5134 View commit details
    Browse the repository at this point in the history

  2. migrations: re-roll migration history 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    20a4e4e View commit details
    Browse the repository at this point in the history

  3. config: register .attestations for inclusion 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a058c41 View commit details
    Browse the repository at this point in the history

  4. attestations: request the appropriate IFileStorage service 

    IFileStorage requires a name to disambiguate it.

Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    19b7739 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into ww/pep740-persisten… 

    …ce-take-2
    @woodruffw
    woodruffw committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    19b4ef8 View commit details
    Browse the repository at this point in the history

  6. conftest: add archive_files.path to get_app_config 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f4a40ad View commit details
    Browse the repository at this point in the history

  7. test, warehouse: remove problematic mocks 

    This removes two mocked `db_request`s from the simple
index tests. These mocks were masking larger architectural
issues with both attestations and our test scaffolding
for attestations.

This isn't quite complete yet, since it does a nasty thing
(uses a file storage with a tmpdir) to get IntegrityService
initialization working.

Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b151b82 View commit details
    Browse the repository at this point in the history

  8. test_services: rename test class 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    64ed3e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Try to clean a bit the mess with the migrations.

    @DarkaMaul
    DarkaMaul committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e19be6c View commit details
    Browse the repository at this point in the history

  2. begin refactoring IntegrityService 

    This reduces the overall API surface for IIntegrityService implementers,
and adds an initial NullIntegrityService to make unit-level testing
simpler.

Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    98b833d View commit details
    Browse the repository at this point in the history

  3. Revert "Try to clean a bit the mess with the migrations." 

    This reverts commit e19be6c.
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4549711 View commit details
    Browse the repository at this point in the history

  4. tests, warehouse: more error tests, remove more stubs 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    77d08a2 View commit details
    Browse the repository at this point in the history

  5. test_services: fix match 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    014f649 View commit details
    Browse the repository at this point in the history

  6. remove more implicit file service deps 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    46f32e2 View commit details
    Browse the repository at this point in the history

  7. continue to burn down coverage 

    Remove more ad-hoc stubs as well.

Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7e7ea8c View commit details
    Browse the repository at this point in the history

  8. full coverage 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fd2a3a8 View commit details
    Browse the repository at this point in the history

  9. test_simple: positive provenance test for /simple 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    899f065 View commit details
    Browse the repository at this point in the history

  10. tests: minimize, increase confidence in behavior 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7b0200d View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'upstream/main' into ww/pep740-persisten… 

    …ce-take-2
    @woodruffw
    woodruffw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    bbb33f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Update warehouse/config.py 

    Co-authored-by: dm <[email protected]>
    @woodruffw @DarkaMaul
    woodruffw and DarkaMaul authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9767c79 View commit details
    Browse the repository at this point in the history

  2. packaging/test_utils: remove another mock 

    Signed-off-by: William Woodruff <[email protected]>
    @woodruffw
    woodruffw committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d92f057 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Remove even more mocks

    @DarkaMaul
    DarkaMaul committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f1e0a27 View commit details
    Browse the repository at this point in the history

  2. Update tests/conftest.py 

    Co-authored-by: William Woodruff <[email protected]>
    @DarkaMaul @woodruffw
    DarkaMaul and woodruffw authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5e5f91e View commit details
    Browse the repository at this point in the history

  3. Update test_create_service

    @DarkaMaul
    DarkaMaul committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2262041 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ww/pep740-persistence-take-2

    @DarkaMaul
    DarkaMaul authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0467f5c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Merge branch 'main' into ww/pep740-persistence-take-2

    @di
    di authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    26e48d2 View commit details
    Browse the repository at this point in the history

  2. Add a functional test

    @di
    di committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    17e9d45 View commit details
    Browse the repository at this point in the history

  3. Linting

    @di
    di committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b8c5423 View commit details
    Browse the repository at this point in the history

  4. Fixup migration

    @di
    di committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    866b0a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Fix test error

    @DarkaMaul
    DarkaMaul committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f4fc53c View commit details
    Browse the repository at this point in the history

  2. Revert change

    @DarkaMaul
    DarkaMaul committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    e72b746 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Rename key

Co-authored-by: Dustin Ingram <[email protected]>
    @DarkaMaul @di
    DarkaMaul and di authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    52931a1 View commit details
    Browse the repository at this point in the history

  4. Revert "Apply suggestions from code review " 

    This reverts commit 52931a1.
    @DarkaMaul
    DarkaMaul committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c9a774f View commit details
    Browse the repository at this point in the history

  5. Give the IntegrityService access to the session

    @di
    di committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f7e277e View commit details
    Browse the repository at this point in the history

  6. Add the Attestation object to the session

    @di
    di committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fa1bd58 View commit details
    Browse the repository at this point in the history

  7. Update the functional test with more assertions

    @di
    di committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4ca217b View commit details
    Browse the repository at this point in the history

  8. Remove vestigial helper

    @di
    di committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9497124 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Update functional test

    @DarkaMaul
    DarkaMaul committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ac783a8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ww/pep740-persistence-take-2

    @di
    di authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    caa181f View commit details
    Browse the repository at this point in the history