Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug issues with duplicate POST keys #16755

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Conversation

di
Copy link
Member

@di di commented Sep 19, 2024

This test should reproduce issues users are having with #16732, but seems to work fine. Fixes #16756.

@di di requested a review from a team as a code owner September 19, 2024 13:47
@di
Copy link
Member Author

di commented Sep 19, 2024

My theory is that trying to cast request.POST to a dict and catching a TypeError is too broad, so I switched this to specifically just counting for duplicate keys instead.

I also added the current URL to the error message for future debugging purposes, and expanded the tests a bit.

@di di merged commit dcadf7a into pypi:main Sep 19, 2024
18 checks passed
@di di deleted the duplicate-post-keys-debug branch September 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPError: 400 Bad Request from https://test.pypi.org/legacy/ Bad Request for Github Actions on Test PyPI
2 participants