REF: Use upper case EPSG code when creating CRS #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowman2
commented
Oct 14, 2022
| @@ -147,7 +147,7 @@ def _prepare_from_authority(auth_name: str, auth_code: Union[str, int]): | |||
|
|
|||
|
|
|||
| def _prepare_from_epsg(auth_code: Union[str, int]): | |||
| return _prepare_from_authority("epsg", auth_code) | |||
| return _prepare_from_authority("EPSG", auth_code) | |||
There was a problem hiding this comment.
This is the main change when creating CRS from_epsg integer.
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 18 18
Lines 1703 1703
=======================================
Hits 1638 1638
Misses 65 65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
klssmith
added a commit
to alphagov/notifications-utils
that referenced
this pull request
Dec 15, 2022
Version 3.4.1 of pyproj changed the ESPG codes to be upper case, which means that our tests now fail (pyproj4/pyproj#1162). This change updates our code to also use upper case codes, and bumps the minimum version of pyproj to ensure that we're always using a version which also uses the upper case codes.
klssmith
added a commit
to alphagov/notifications-utils
that referenced
this pull request
Dec 15, 2022
Version 3.4.1 of pyproj changed the ESPG codes to be upper case, which means that our tests now fail (pyproj4/pyproj#1162). This change updates our code to also use upper case codes, and bumps the minimum version of pyproj to ensure that we're always using a version which also uses the upper case codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EPSG database uses the uppercase version. This is for consistency with
to_authority.