PERF: thread local context #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
snowman2
force-pushed
the
thread_local_context
branch
2 times, most recently
from
338b615
to
2b8c42c
Compare
snowman2
force-pushed
the
thread_local_context
branch
from
2b8c42c
to
a4d7684
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
+ Coverage 96.40% 96.45% +0.04%
==========================================
Files 20 20
Lines 1810 1804 -6
==========================================
- Hits 1745 1740 -5
+ Misses 65 64 -1 ☔ View full report in Codecov by Sentry. |
|
Considering merging this for this release. I haven't seen any issues so far. If you have time to test it with other repos that use pyproj, that would be helpful. |
|
#1316 may be helpful for testing... |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Oct 1, 2024
(Tests fail with environment issues, but one can load pyproj outside of the test environment. Filed upstream.) Enhancements: * PERF: drop GIL during long-running proj database calls by @tpwrules in pyproj4/pyproj#1354 * PERF: thread local context by @snowman2 in pyproj4/pyproj#1419 * ENH: Add is_deprecated and get_non_deprecated() to CRS by @jjimenezshaw in pyproj4/pyproj#1383 * ENH: Add runtime & compiled PROJ versions by @snowman2 in pyproj4/pyproj#1427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
history.rstfor all changes andapi/*.rstfor new API