Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove from MANIFEST.in obsolete and automatically included files #247

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Apr 6, 2019

Avoid warnings for files not found.


I have tested setup.py sdist (Python 3.7.3, setuptools 40.6.3) but my interest was removing warnings - please check it creates the required tarball for releases from your workflow.

MANIFEST.in Outdated Show resolved Hide resolved
@snowman2
Copy link
Member

snowman2 commented Apr 6, 2019

Thanks for this - will be good to keep this updated.

@snowman2 snowman2 requested a review from jswhit April 6, 2019 20:57
@snowman2
Copy link
Member

@cjmayo what are your thoughts on the comment above?

@cjmayo
Copy link
Contributor Author

cjmayo commented Apr 24, 2019

@cjmayo what are your thoughts on the comment above?

Which comment (didn't get any email notifications)?

Copy link
Member

@snowman2 snowman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which comment (didn't get any email notifications)?

Just was curious about your thoughts on adding recursive-include test * to the manifest (see above).

MANIFEST.in Show resolved Hide resolved
@snowman2 snowman2 merged commit e93853b into pyproj4:master Apr 25, 2019
@snowman2
Copy link
Member

Thanks @cjmayo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants