Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readme and intro fix #1007

Merged
merged 6 commits into from
Apr 30, 2024
Merged

add readme and intro fix #1007

merged 6 commits into from
Apr 30, 2024

Conversation

pz-max
Copy link
Member

@pz-max pz-max commented Apr 21, 2024

Closes # (if applicable).

Add figures and references to power system examples. People need to have a quick lick to Davide's zenodo repo.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max
Copy link
Member Author

pz-max commented Apr 21, 2024

Docs changes:
image

  • Readme changes are just a figure description.

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pz-max !
A little comment, what do you think?

doc/index.rst Outdated Show resolved Hide resolved
@pz-max
Copy link
Member Author

pz-max commented Apr 27, 2024

Good point 👍🏽 I will use them just the links from the read e image

@pz-max
Copy link
Member Author

pz-max commented Apr 27, 2024

@davide-f

Thanks @pz-max ! A little comment, what do you think?

Changes accepted. Added now additionally some of the "how the docs" bits in the Contribute Section. The "how the docs" page was previously fully omitted. Feel free to merge when its fine.

FYI, also changed in the readthedocs admin options that there should be an independent docs build per PR such that we can review more easily. I guess it will be build with the next PR.

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Max :) I've fixed a refuse, merging as CI passes

@pz-max
Copy link
Member Author

pz-max commented Apr 29, 2024

@davide-f, I think there is a misunderstanding. I think the Readme pictures should be in the documentation. Not everybody is reading the Readme, and some non-dev people will default to the documentation. The global modelling pictures as well as the description to more model pictures is very useful (Tom B or others never find those).

So, my suggestion with the openmod image links was intended and, in my opinion, that is not a big overhead. This PR has nothing to do with the general docs picture architecture suggestion in Discord. If you agree, can you revert your commit? Happy to discuss in the next dev meeting

@davide-f
Copy link
Member

Agree @pz-max , apologies; I reset the previous change.
As CI passes, it gets merged :)

@davide-f davide-f merged commit 0be75af into pypsa-meets-earth:main Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants