-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add readme and intro fix #1007
add readme and intro fix #1007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pz-max !
A little comment, what do you think?
Changes accepted. Added now additionally some of the "how the docs" bits in the Contribute Section. The "how the docs" page was previously fully omitted. Feel free to merge when its fine. FYI, also changed in the readthedocs admin options that there should be an independent docs build per PR such that we can review more easily. I guess it will be build with the next PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Max :) I've fixed a refuse, merging as CI passes
@davide-f, I think there is a misunderstanding. I think the Readme pictures should be in the documentation. Not everybody is reading the Readme, and some non-dev people will default to the documentation. The global modelling pictures as well as the description to more model pictures is very useful (Tom B or others never find those). So, my suggestion with the openmod image links was intended and, in my opinion, that is not a big overhead. This PR has nothing to do with the general docs picture architecture suggestion in Discord. If you agree, can you revert your commit? Happy to discuss in the next dev meeting |
Agree @pz-max , apologies; I reset the previous change. |
Closes # (if applicable).
Add figures and references to power system examples. People need to have a quick lick to Davide's zenodo repo.
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.