Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug to run the cluster wildcard min #1019

Merged
merged 2 commits into from
May 2, 2024

Conversation

virio-andreyana
Copy link
Contributor

@virio-andreyana virio-andreyana commented May 1, 2024

Its a minor bugfix so that the cluster wildcard option min can be run on snakemake without error

  • In Snakefile, min doesn't require any number, similar to all
  • In cluster_network.py, the number of network after determine_network_topology() is always larger than the original n_cluster. A network copy is made to count that, but better suggestion is appreciated.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@virio-andreyana virio-andreyana changed the title Fix bug to run the cluster wildcard 'min' Fix bug to run the cluster wildcard min May 1, 2024
scripts/cluster_network.py Outdated Show resolved Hide resolved
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @virio-andreyana :D

@davide-f davide-f merged commit 496bb91 into pypsa-meets-earth:main May 2, 2024
5 checks passed
@virio-andreyana virio-andreyana deleted the fix-min-wildcard branch June 24, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants