Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused argument from load_GDP #1069

Merged

Conversation

ollie-bell
Copy link
Contributor

@ollie-bell ollie-bell commented Jul 31, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Remove unused countries_codes argument from load_GDP function in build_shapes.py script.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@ollie-bell
Copy link
Contributor Author

ollie-bell commented Jul 31, 2024

This unused argument was not being considered when calling the function. Because these are passed as positional arguments, they were not being passed as intended (e.g. update was taking the value of out_logging)

GDP_tif, name_tif = load_GDP(year, update, out_logging, name_file_nc)

@davide-f
Copy link
Member

davide-f commented Aug 1, 2024

Many thanks @ollie-bell !
Would you like to add a minor release note? :)

@ollie-bell
Copy link
Contributor Author

Many thanks @ollie-bell ! Would you like to add a minor release note? :)

Done!

@davide-f davide-f merged commit d5aed4e into pypsa-meets-earth:main Aug 4, 2024
5 checks passed
@davide-f
Copy link
Member

davide-f commented Aug 4, 2024

Welcome among contributors @ollie-bell :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants