Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world_iso list modified #330

Merged
merged 7 commits into from
May 27, 2022
Merged

Conversation

HanaElattar
Copy link
Contributor

@HanaElattar HanaElattar commented Apr 28, 2022

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@HanaElattar HanaElattar marked this pull request as ready for review April 28, 2022 12:16
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contributions! Very detailed work :)
I added few simple comments.

Moreover, the pre-commit is not working.
To successfully use it, I recommend you to do as in https://pypsa-meets-africa.readthedocs.io/en/latest/installation.html , in particular:

  • Use an IDE to edit python (recommended Visual Studio Code that is open)
  • Install the pypsa-africa environment (see guide)
  • Always make edits and commits after having enabled the environment [In VSCode, this may be easily done automatically by setting View->Command Pallette->Python Interpreter->pypsa-africa)

scripts/config_osm_data.py Outdated Show resolved Hide resolved
scripts/config_osm_data.py Outdated Show resolved Hide resolved
scripts/config_osm_data.py Outdated Show resolved Hide resolved
@davide-f
Copy link
Member

davide-f commented May 3, 2022

@HanaElattar , if you need any help on the above, feel free to write on Discord or here :)

@HanaElattar
Copy link
Contributor Author

Added a list of countries but couldn't test that the workflow runs. Could be for future work.

@pz-max pz-max merged commit 5dcb47f into pypsa-meets-earth:main May 27, 2022
pz-max added a commit that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants