-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
world_iso list modified #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contributions! Very detailed work :)
I added few simple comments.
Moreover, the pre-commit is not working.
To successfully use it, I recommend you to do as in https://pypsa-meets-africa.readthedocs.io/en/latest/installation.html , in particular:
- Use an IDE to edit python (recommended Visual Studio Code that is open)
- Install the pypsa-africa environment (see guide)
- Always make edits and commits after having enabled the environment [In VSCode, this may be easily done automatically by setting View->Command Pallette->Python Interpreter->pypsa-africa)
@HanaElattar , if you need any help on the above, feel free to write on Discord or here :) |
for more information, see https://pre-commit.ci
Added a list of countries but couldn't test that the workflow runs. Could be for future work. |
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.