Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize CRS in the workflow #356

Merged
merged 27 commits into from
May 31, 2022
Merged

Harmonize CRS in the workflow #356

merged 27 commits into from
May 31, 2022

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented May 30, 2022 •
edited
Loading

Closes #297

Changes proposed in this Pull Request

This PR aims at harmonizing the CRSs used in the workflow as follows:

  • Avoid having "magic" epsg specifications along the text: constant values are used in the scripts according to the file that are downloaded
  • In the config files default and metric crs is proposed

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f changed the title Verify epsg Harmonize CRS in the workflow May 30, 2022
pz-max
pz-max reviewed May 30, 2022
View reviewed changes
config.tutorial.yaml Outdated Show resolved Hide resolved
@davide-f davide-f marked this pull request as ready for review May 30, 2022 16:53
@davide-f davide-f requested a review from pz-max May 30, 2022 17:21
pz-max
pz-max reviewed May 30, 2022
View reviewed changes
scripts/build_renewable_profiles.py Outdated Show resolved Hide resolved
scripts/build_renewable_profiles.py Outdated Show resolved Hide resolved
scripts/build_osm_network.py Outdated Show resolved Hide resolved
config.default.yaml Outdated Show resolved Hide resolved
@davide-f davide-f requested a review from pz-max May 30, 2022 22:03
pz-max
pz-max approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@pz-max pz-max left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Ready to merge? @davide-f

@davide-f
Copy link
Member Author

Looks great. Ready to merge? @davide-f

Yes :)

@pz-max pz-max merged commit 9815772 into pypsa-meets-earth:main May 31, 2022
@davide-f davide-f deleted the verify_epsg branch June 9, 2022 22:45
pz-max added a commit that referenced this pull request Sep 24, 2022
@pz-max
Merge pull request #356 from davide-f/verify_epsg
8042eab 
Harmonize CRS in the workflow
FabianHofmann pushed a commit that referenced this pull request Aug 16, 2024
@davide-f
Merge pull request #356 from pypsa-meets-earth/scenario_setup
7f88c62 
Include scenario management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pz-max pz-max pz-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonize Coordinate Reference Systems (CRS) and set them as configuration options
2 participants
@davide-f @pz-max