Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voronoi cell plot and create plot function #369

Merged
merged 11 commits into from
Jun 5, 2022
Merged

Add voronoi cell plot and create plot function #369

merged 11 commits into from
Jun 5, 2022

Conversation

pz-max
Copy link
Member

@pz-max pz-max commented Jun 4, 2022

New plot example:

solar-gridcell
solar-cell
output

Checklist

  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max
Copy link
Member Author

pz-max commented Jun 4, 2022

@davide-f I just updated the build_cutout, land-availability and build_renewables notebooks over the past days. Feel free to check them out 👍 . I show the illustrations in the notebook. As mentioned, in future we clean the history and put such nice plot examples in another repository & maybe add a submodule or whatever makes sense.

Feel free to merge this PR.

@davide-f
Copy link
Member

davide-f commented Jun 4, 2022

Please @pz-max , may you check the files? they seem corrupted and pre-commit is also failing unfortunately

@pz-max
Copy link
Member Author

pz-max commented Jun 4, 2022

Weird error. I reverted with the below approach now: https://stackoverflow.com/questions/610208/how-to-retrieve-a-single-file-from-a-specific-revision-in-git

The easiest way is to write:

git show HASH:file/path/name.ext > some_new_name.ext

where:

HASH is the Git revision SHA-1 hash number
file/path/name.ext is name of the file you are looking for
some_new_name.ext is path and name where the old file should be saved

@pz-max
Copy link
Member Author

pz-max commented Jun 4, 2022

ready to merge @davide-f

@davide-f
Copy link
Member

davide-f commented Jun 4, 2022

Super!
I'd suggest to stick to use the same EPSG values though.
Is there a specific reason why you used "epsg:3395"? It is eurocentric, though it should not lead to major issues

@pz-max
Copy link
Member Author

pz-max commented Jun 4, 2022 via email

@davide-f
Copy link
Member

davide-f commented Jun 5, 2022

@pz-max Is this ready to merge?

@pz-max
Copy link
Member Author

pz-max commented Jun 5, 2022

@pz-max Is this ready to merge?

Yes

@davide-f davide-f merged commit a4507bc into pypsa-meets-earth:main Jun 5, 2022
pz-max pushed a commit that referenced this pull request Sep 24, 2022
Add voronoi cell plot and create plot function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants