-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add converters as links and enable DC #392
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Test on the continental scale runs but I was not able to achieve any improvements regarding the infeasibility. Gurobi refuses to operate without a proper license for that size of problem (understandable) while working with the glpk interface was found to be not quite obvious :)) An additional problem found during testing for the continent were troubles for HVDC line in Namibia. The weights both from the generator and the load parts are by some reason zero which leads to division by zero: Have introduced a quick fix but I think it makes sense to look a bit more careful into that. Not necessarily as a part of this PR :) |
Note to the network pictures above: now connections of the DC buses to the lines were improved. The result is that the DC buses are kept in the network model without any additional settings (like a requirement to match the carrier during the stubs removal). |
@ekatef Very nice, few comments:
|
@davide-f, many thanks for checking! That's is always a bit of a challenge to finalise properly something more or less big :) And your support is a huge help in that. To answer point-by-point:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekatef Awesome! Few comments before merging :)
for more information, see https://pre-commit.ci
@ekatef super! PR merged, thank you very much for the great work! |
@davide-f thank you for supporting it :) It was a pleasure to contribute! |
Add converters as links and enable DC
Closes #385
Changes proposed in this Pull Request
The aim of the PR is to enable DC carrier in the network model and include converters as Link component
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.