-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the use of a float value for the scale in load_options #397
Enable the use of a float value for the scale in load_options #397
Conversation
This PR is raised because I faced an error when using a float value for the scale in load_options: "typeerror: can't multiply sequence by non-int of type 'float'". The PR is a simple fix for this error where only the column of "Electricity demand" is multiplied by the float value, the other string columns are not multiplied. |
Hey @AnasAlgarei awesome to see your first contribution. |
Hey @davide-f! Thanks for your reply |
@AnasAlgarei if you add the readme this PR is ready to merge 💯 |
for more information, see https://pre-commit.ci
…i/pypsa-africa into add_electricity_scale
@AnasAlgarei you fix here a big. Float values couldn't be used in the past. GIving a hint in the release docs would be helpful. I merge this PR anyways if the CI is successful. Congrats on your first contribution 👯 |
Great! Thanks for the hints @pz-max and @davide-f, I added a note in the release notes though, looking forward to future contributions 😊 |
Enable the use of a float value for the scale in load_options
Changes proposed in this Pull Request
The aim of the PR is to enable the use of a float value for the scale in load_options in the config file.
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.