fixed the bug with attaching hydro for GADM clustering #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
davide-f
reviewed
Aug 3, 2022
There was a problem hiding this comment.
Good @hazem! :)
Please, add a comment in the release_note.
Moreover, there are problems with linter, when you add commits, please activate the pypsa-africa environment with the pre-commit enabled so that it automatically check the format.
Alternatively, you can run pre-commit run to manually check the current staged files
In general, as discussed, we shall need a more general solution in the future and we need to add an issue to address that.
In particular, in the new issue, we should specify to try decompose the dependencies of options across multiple scripts, such as for alternative_clustering.
Please, check the comments and then we can merge this :)
davide-f
approved these changes
Aug 3, 2022
pz-max
pushed a commit
that referenced
this pull request
Sep 24, 2022
fixed the bug with attaching hydro for GADM clustering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #426
Changes proposed in this Pull Request
Checklist
I tested my contribution locally and it seems to work fine.
Code and workflow changes are sufficiently documented.
A note for the release notes
doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.