Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise methodology to calculate databundle outputs #529

Merged

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Dec 1, 2022

Closes #519

Changes proposed in this Pull Request

This is a fix to identify the outputs of the retrieve_databundle depending on the bundles that are being downloaded given the set of countries that has been specified

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f marked this pull request as draft December 1, 2022 19:26
@davide-f davide-f marked this pull request as ready for review December 1, 2022 19:51
@davide-f davide-f requested a review from pz-max December 6, 2022 16:20
Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pz-max pz-max merged commit 7193c2a into pypsa-meets-earth:main Dec 8, 2022
@davide-f davide-f deleted the revise_databundle_outputs_calc branch March 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retrieve_databundle_light data download problem for new regions
2 participants