Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type conversion in simplify #553

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Jan 2, 2023

Closes #552

Changes proposed in this Pull Request

This is a simple fix for issue #552 .
The problem was related to type conversions when using the dataframe.loc = pd.Series
This is general bug fixing; no need to add a release_note for that

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions regarding loose comments otherwise this looks good

scripts/simplify_network.py Outdated Show resolved Hide resolved
@davide-f davide-f merged commit b745abe into pypsa-meets-earth:main Jan 6, 2023
@davide-f davide-f added this to the Country-wise model milestone Feb 1, 2023
@davide-f davide-f deleted the fix_simplify branch March 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netcdf4 conversion problem in simplify_network
2 participants