Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes #580

Merged
merged 19 commits into from
Jan 26, 2023
Merged

Various bug fixes #580

merged 19 commits into from
Jan 26, 2023

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Jan 25, 2023

Closes #451
Closes #106
Closes also not-opened issues

Changes proposed in this Pull Request

This PR contains various improvements and bug fixing along the workflow

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f mentioned this pull request Jan 25, 2023
@@ -301,6 +301,18 @@ def estimate_bus_loss(data_column, tech):
return share_missed_buses


def filter_cutout_region(cutout, regions):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fneum maybe interesting for PyPSA-Eur?
When you have a EU cutout, you will only create the renewable profiles in the country of interest

scripts/simplify_network.py Outdated Show resolved Hide resolved
@davide-f
Copy link
Member Author

@pz-max ready to finalize

@pz-max pz-max enabled auto-merge January 26, 2023 14:19
@pz-max pz-max merged commit dfd9117 into pypsa-meets-earth:main Jan 26, 2023
@davide-f davide-f deleted the various_bug_fixes branch March 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine line voltage fix remove snakemake dependecies from functions
2 participants