-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse_improve #662
reuse_improve #662
Conversation
for more information, see https://pre-commit.ci
.reuse/dep5
Outdated
|
||
Files: .github/* | ||
Copyright: The PyPSA-Earth and PyPSA-Eur Authors | ||
License: CC0-1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juli-a-ko, after giving some thoughts to dep5, I fear that .github/*
files should be included there. The reason is templates which are placed in .github
directory. License headers make working with the templates difficult, which has caused need of urgent changes
If I understand properly, that mean we have to leave .github/*
in dep5
. Could you please double-check this logic and adjust the PR accordingly?
@juli-a-ko thanks a lot for the PR! Looks great, except a question regarding |
for more information, see https://pre-commit.ci
Ок, I left .github/* directory in dep5 file |
@pz-max, my feeling is that this PR ready for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This completes now the REUSE compatibility implementation. Thank you @juli-a-ko. It's good to have now at least three REUSE experts. Also, welcome to the contributor list 🥇 💯 Feel free to merge @ekatef
Thanks a lot @juli-a-ko and @pz-max! :) |
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.