Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse_improve #662

Merged
merged 5 commits into from
Apr 3, 2023
Merged

reuse_improve #662

merged 5 commits into from
Apr 3, 2023

Conversation

juli-a-ko
Copy link
Contributor

@juli-a-ko juli-a-ko commented Apr 2, 2023

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I consent to the release of this PR's code under the GPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

.reuse/dep5 Outdated
Comment on lines 17 to 20

Files: .github/*
Copyright: The PyPSA-Earth and PyPSA-Eur Authors
License: CC0-1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juli-a-ko, after giving some thoughts to dep5, I fear that .github/* files should be included there. The reason is templates which are placed in .github directory. License headers make working with the templates difficult, which has caused need of urgent changes

If I understand properly, that mean we have to leave .github/* in dep5. Could you please double-check this logic and adjust the PR accordingly?

@ekatef
Copy link
Member

ekatef commented Apr 2, 2023

@juli-a-ko thanks a lot for the PR! Looks great, except a question regarding dep5. Would be very grateful if you could address it :)

@juli-a-ko
Copy link
Contributor Author

Ок, I left .github/* directory in dep5 file

@ekatef
Copy link
Member

ekatef commented Apr 3, 2023

Ок, I left .github/* directory in dep5 file
Super, thanks a lot for the discussion and making the changes!

@pz-max, my feeling is that this PR ready for your review

Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This completes now the REUSE compatibility implementation. Thank you @juli-a-ko. It's good to have now at least three REUSE experts. Also, welcome to the contributor list 🥇 💯 Feel free to merge @ekatef

@ekatef ekatef merged commit ab3ba36 into pypsa-meets-earth:main Apr 3, 2023
@ekatef
Copy link
Member

ekatef commented Apr 3, 2023

Thanks a lot @juli-a-ko and @pz-max! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants