Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask patch. Close dask client #761

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Conversation

pz-max
Copy link
Member

@pz-max pz-max commented Jun 13, 2023

Changes proposed in this Pull Request

The dask implementation was breaking for Windows.
Closing the client solves the issue.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max
Copy link
Member Author

pz-max commented Jun 13, 2023

The previous test was working now also in WINDOWS. Merging the PR.

  • pre-commit issue has nothing to do with these changes and was observed in previous PR

@pz-max pz-max merged commit b2d1928 into pypsa-meets-earth:main Jun 13, 2023
@pz-max pz-max deleted the dask-patch branch June 13, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant