-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-commit and revise style #779
Conversation
@@ -337,8 +337,8 @@ monte_carlo: | |||
# Key: add below the pypsa object for the monte_carlo sampling, "network" is only allowed for filtering! | |||
# Value: currently supported format [l_bound, u_bound] or empty [], represent multiplication factors for the object | |||
loads_t.p_set: [0.9, 1.1] | |||
generators_t.p_max_pu.loc[:, n.generators.carrier == "wind"]: [0.9, 1.1] | |||
generators_t.p_max_pu.loc[:, n.generators.carrier == "solar"]: [0.9, 1.1] | |||
# generators_t.p_max_pu.loc[:, n.generators.carrier == "wind"]: [0.9, 1.1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davide-f we need at least two rows to test the Monte-Carlo stuff. Test is currently failing because of that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a commit to fix this... let's see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recreated the PR and kept this line commented out.
pretty YAML crashes with checking those lines. In this PR, there is a fix to monte_carlo caospy to make sure that it works even with a single parameter in the list of monte carlos. The other options have been tested as well.
pre-commit is failing with
I think because of the recent PR that we merged, @davide-f you need to run locally the pre-commit and add the fixes that the docformatter is suggesting. Can you do that? |
@pz-max the yaml block of the pre-commit is failing because it cannot handle "generators_t.p_max_pu.loc[:, n.generators.carrier == "wind"]: [0.9, 1.1]" Therefore, I commented these two lines in the tutorial and default configs. That lead instead to issues in the CI.
Since @pz-max, you worked in the monte carlo, what is your feeling there? |
@pz-max The PR has been rewritten and force-pushed with the following changes:
|
@pz-max PEP 257 is there, if CI passes this PR can be merged. Locally seems ok |
Changes proposed in this Pull Request
Fix to pre-commit.
The pre-commit has also been partially aligned to the one by pypsa-eur
I feel that this may conflict with other PRs, including #701
#701 shall be first reviewed and merged before fixing this.
Everything can be done in few hours