Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quick fix for underwater_fraction calculations #816

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

ekatef
Copy link
Member

@ekatef ekatef commented Jul 29, 2023

Closes #765

Remove re-calculation of underwater_fraction after augmentation to fix problems which can arise for networks with HVDC lines due to empty n.links.geometry after simplification.

Augmentation of networks with HVDC part should be anyway improved which may be tracked in #765.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@ekatef ekatef mentioned this pull request Jul 29, 2023
8 tasks
@ekatef
Copy link
Member Author

ekatef commented Jul 29, 2023

@davide-f that is "raw fix" implementation we discussed in #768.
Ready for review :)

@davide-f
Copy link
Member

Perfect :) no need for release note I'd say.
Merging

@davide-f davide-f merged commit 071718c into pypsa-meets-earth:main Jul 29, 2023
3 checks passed
@ekatef ekatef deleted the quick_fix_line_augm branch November 14, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise augmentation procedure for networks with HVDC part
2 participants