Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run world latest #817

Merged
merged 12 commits into from
Aug 5, 2023
Merged

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Aug 2, 2023

Closes # (if applicable).

Changes proposed in this Pull Request

Include fixes and improvements to enable the execution of the default configuration for every country in the world

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f marked this pull request as ready for review August 2, 2023 21:33
scripts/simplify_network.py Show resolved Hide resolved
@ekatef
Copy link
Member

ekatef commented Aug 4, 2023

Hello Davide! :D

My impression is that you have managed to make the code cleaner when adding the fixes. Fantastic work!

Basically, I have not much to add. The amended suggestion relates to the old version, not to the PR itself. Feel free to disregard in case 🙂

@davide-f davide-f merged commit fcb6668 into pypsa-meets-earth:main Aug 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants