-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove "scripts." in snakefile #926
Conversation
Hi @davide-f , PS: Do you know, why the pipeline doesnt work? Is it still because of the zenodo issue or is it because of my adjustments? |
Great @doneachh :D Could you parse the changes here? I'd like a CI to work to merge this PR, we can launch a CI early tomorrow, or if you commit early tomorrow, that should do the trick in the meantime... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On top of the above, please, there is a missing "scripts." in:
Line 1046 in 726c010
from scripts.build_test_configs import create_test_config |
Hi @davide-f :D |
CI passing, merging :) you may investigate if we can use the get_commit function from the pypsa-earth submodule instead of copying it into the -sec version, but that's not necessary Great :D |
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.