Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved conflict with packages #939

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Conversation

GbotemiB
Copy link
Contributor

@GbotemiB GbotemiB commented Dec 18, 2023

Closes 936# (if applicable).

Changes proposed in this Pull Request

This PR suggests a fix for the environment file due to the recent update with earth-osm.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@GbotemiB GbotemiB marked this pull request as ready for review December 18, 2023 23:19
@davide-f
Copy link
Member

Mmm nice to fix the issue!
As a comment, maybe the function has changed name, could you check:
https://github.com/pypsa-meets-earth/earth-osm/blob/714ab0d9762d3715fdd1ebb1eba6af1773070004/earth_osm/eo.py#L122

@davide-f
Copy link
Member

davide-f commented Dec 23, 2023

Hello @GbotemiB!
I investigated the problem and completely agree that a quick fix is recommended.
Please, could you:

  • revert the change in the file environment.fixed: never edit that file during PRs, it is only updated after a new version
  • please, instead of fiing the xarray with ==, please use "<=". Is that fix necessary?

Once that is done, we can merge this PR :)

When do you think you could do this?
Unfortunately I may need this today but I could step in if you agree

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed

@GbotemiB
Copy link
Contributor Author

GbotemiB commented Dec 23, 2023

Hello @GbotemiB! I investigated the problem and completely agree that a quick fix is recommended. Please, could you:

  • revert the change in the file environment.fixed: never edit that file during PRs, it is only updated after a new version
  • please, instead of fiing the xarray with ==, please use "<=". Is that fix necessary?

Once that is done, we can merge this PR :)

When do you think you could do this? Unfortunately I may need this today but I could step in if you agree

Thanks @davide-f, I will make the changes as soon as possible.

@GbotemiB
Copy link
Contributor Author

Hello @davide-f, I have reviewed the yaml files.

@GbotemiB
Copy link
Contributor Author

GbotemiB commented Dec 23, 2023

I have also reset, the history to make it cleaner. If you need to make additional changes before merging, please feel free to.

Thanks @davide-f.

@davide-f davide-f merged commit 977c6c2 into pypsa-meets-earth:main Dec 23, 2023
4 checks passed
@GbotemiB GbotemiB deleted the env_fix branch December 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Earth-OSM latest version(0.2.0) not compatible
2 participants