code cleanups

pyrevitlabs · Jun 21, 2021 · 4e949af · 4e949af
1 parent 252e8ca
commit 4e949af
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/...on/pyRevitDev.tab/Debug.panel/Unit Tests.pulldown/Forms Module Tests.pushbutton/script.py b/...on/pyRevitDev.tab/Debug.panel/Unit Tests.pulldown/Forms Module Tests.pushbutton/script.py
@@ -47,6 +47,16 @@ def test_forms(forms_func, test_title, filterfuncstr='', *args, **kwargs):
     ))
 
 
+print(
+    forms.ask_for_number_slider(
+        default='test default',
+        prompt='test prompt',
+        title='test title',
+        min=12,
+        max=100
+    ))
+
+
 print(
     forms.ask_for_one_item(
         ['test item 1', 'test item 2', 'test item 3'],

diff --git a/pyrevitlib/pyrevit/forms/__init__.py b/pyrevitlib/pyrevit/forms/__init__.py
@@ -1191,8 +1191,6 @@ def _setup(self, **kwargs):
         value_prompt = kwargs.get('prompt', None)
         value_default = kwargs.get('default', None)
         self.reserved_values = kwargs.get('reserved_values', [])
-        value_max = kwargs.get('max', 100)
-        value_min = kwargs.get('min', 0)
 
         # customize window based on type
         if self.value_type == 'string':
@@ -1218,9 +1216,11 @@ def _setup(self, **kwargs):
         elif self.value_type == 'slider':
             self.show_element(self.sliderPanel_sp)
             self.sliderPrompt.Text = value_prompt
-            self.numberPicker.Minimum = value_min
-            self.numberPicker.Maximum = value_max
-            self.numberPicker.Value = value_default if value_default else self.numberPicker.Value.MaximizeValue
+            self.numberPicker.Minimum = kwargs.get('min', 0)
+            self.numberPicker.Maximum = kwargs.get('max', 100)
+            self.numberPicker.Value = \
+                value_default if isinstance(value_default, float) \
+                    else self.numberPicker.Minimum
 
     def string_value_changed(self, sender, args): #pylint: disable=unused-argument
         """Handle string vlaue update event."""