Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASCII Keynote Conversion Failed #1206

Closed
nghesi opened this issue Mar 30, 2021 · 5 comments
Closed

ASCII Keynote Conversion Failed #1206

nghesi opened this issue Mar 30, 2021 · 5 comments
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Prioritize The issue is planned to be resolved in the next version

Comments

@nghesi
Copy link

nghesi commented Mar 30, 2021

As title, latest 4.8.6 verision installed. Conversion fail lead to loosing all contents without any option to recover
@eirannejad eirannejad changed the title ANCSII Keynotes file conversion fail - no backup saved, lost all content ASCII Keynote Conversion Failed Mar 30, 2021
@eirannejad
Copy link
Collaborator

eirannejad commented Mar 30, 2021 •
edited
Loading

@nghesi pyRevit backs up the original keynote file in the same directory with the .bak extension. Change that to .txt and you will have the original text file

Send me the file is possible so I can look at the errors

@nghesi
Copy link
Author

nghesi commented Mar 31, 2021

Keynotefiles.txt
I have to save as the file using UTF-16 format then the conversion is successful. However the issue may destroy the file completely which is a disaster

@eirannejad
Copy link
Collaborator

Okay test and confirmed the issue. This is BAD. :D I'll fix for next release

@eirannejad eirannejad added Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Prioritize The issue is planned to be resolved in the next version labels Mar 31, 2021
eirannejad added a commit that referenced this issue Apr 1, 2021
@eirannejad
fixed issue #1206 [tool][
e95d2b5
@eirannejad
Copy link
Collaborator

Fixed and will be published with next release

  • No longer leaves the keynote file empty if conversion crashes
  • Now reads ASCII files with characters from Windows-1252 and ISO-8859-1 codepages

@eirannejad
Copy link
Collaborator

For the record, the issue was reading an ASCII file with extended characters from other codepages (e.g. Ø from ISO-8859-1 in this case) in strict encoding=ascii mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Prioritize The issue is planned to be resolved in the next version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eirannejad @nghesi