Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrated "if no link" + some project info #1123

Merged
merged 11 commits into from
Jan 15, 2021
Merged

integrated "if no link" + some project info #1123

merged 11 commits into from
Jan 15, 2021

Conversation

jmcouffin
Copy link
Contributor

No description provided.

@eirannejad
Copy link
Collaborator

eirannejad commented Jan 15, 2021

@jmcouffin

  • What's the .idea/ files? Are they needed to be part of the repo?
  • Would you mind fixing this bug as well?

Screen Shot 2021-01-15 at 9 29 22 AM

@jmcouffin
Copy link
Contributor Author

My bad for the idea files. Was trying to get the stubs to work again this morning and. Tried atom and sublime. I should have controlled the files. I will complete the pr with the proper file, I fixed the bug already

Copy link
Contributor Author

@jmcouffin jmcouffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the idea files

@jmcouffin
Copy link
Contributor Author

I think I properly fixed my PR. please do review.
I am sure there are some improvements possible. with my almost noob experience, I cannot figure out the grand scheme organization improvement, where to put def, modules parts and all. Your insight would be greatly appreciated @eirannejad
I will try to add some more bricks to the QC/model chacker next week.

@eirannejad eirannejad merged commit 54612b5 into pyrevitlabs:develop Jan 15, 2021
@eirannejad
Copy link
Collaborator

@jmcouffin You're doing absolutely amazing. Don't take my comments and changes as negative feedback. I'm not better believe me. Just working together to improve pyRevit as much as we can 👍

Merged this to review right now

@eirannejad
Copy link
Collaborator

Runs beautifully now. Officially merged this to develop! Thank you so much for the support @jmcouffin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants