Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix assembly cache #1777

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix assembly cache #1777

merged 1 commit into from
Jun 12, 2023

Conversation

dosymep
Copy link
Member

@dosymep dosymep commented Mar 30, 2023

for issue
#1776

@dosymep
Copy link
Member Author

dosymep commented Mar 30, 2023

I can't create unit tests because pyrevit loses the cache after a reboot and thus several assemblies appear in memory when restarted

@dosymep
Copy link
Member Author

dosymep commented Mar 30, 2023

Maybe this changes needs to thorough check:

  1. when assembly non change (in memory one image)
  2. when assembly was changed (in memory several image)
  3. when pyrevit was reloaded and assembly non change
  4. when pyrevit was reloaded and assembly was changed
  5. etc

@jmcouffin jmcouffin requested a review from eirannejad May 24, 2023 10:13
@jmcouffin jmcouffin added Bundles Issues related to the pyRevit bundles [subsystem] Prioritize The issue is planned to be resolved in the next version labels May 24, 2023
This was referenced May 24, 2023
Closed
Closed
This was linked to issues May 24, 2023
Invoke Button - Error #1824
Closed
Error invoking .NET external command #1373
Closed
Dynamic generated runtime assembly for C# Assembly Extension #1697
Closed
Assembly cache not working #1776
Closed
@eirannejad eirannejad self-assigned this Jun 12, 2023
@eirannejad eirannejad changed the base branch from develop to dev/1777 June 12, 2023 08:49
@eirannejad eirannejad merged commit 93e3a14 into pyrevitlabs:dev/1777 Jun 12, 2023
@eirannejad
Copy link
Collaborator

Merged into develop and will be released with next version very soon. Thanks @dosymep

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0858-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0910-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0908-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1046-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1150-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1153-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23164+0946-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23165+1014-wip

@dosymep dosymep deleted the dev/1776 branch June 15, 2023 06:13
@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23166+0843-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+0833-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1018-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1041-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23177+1038-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23181+1652-wip

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

📦 New public release are available for 4.8.13.23182+2215

@dosymep dosymep mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirannejad eirannejad Awaiting requested review from eirannejad

Assignees

@eirannejad eirannejad

Labels
Bundles Issues related to the pyRevit bundles [subsystem] Prioritize The issue is planned to be resolved in the next version
Projects
None yet
Milestone
No milestone
3 participants
@dosymep @eirannejad @jmcouffin