fix: recursion on emojis renderer #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good. |
|
Since there's only one test, it's too soon for a test step in the CI pipeline to be useful, so I'll defer it for another time |
|
📦 New public release are available for 4.8.15.24089+0912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2104
Since this doesn't depend on Revit APIs, I added a unit test project that could be inserted in the CI pipeline (I will add it soon).
This still uses png icons, I'll tackle the unicode chars / emojis font in a separate PR.
This could be cherry picked in devel branch without any problem