Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nontrivially shaped bint domains #322

Closed
fritzo opened this issue Mar 25, 2020 · 2 comments
Closed

Support nontrivially shaped bint domains #322

fritzo opened this issue Mar 25, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@fritzo
Copy link
Member

fritzo commented Mar 25, 2020

Motivation: this is required for e.g. Independent(Categorical) distributions and for Function tensors that input or output batched categoricals.

I believe this is a big change requiring pervasive updates to all shaping logic.

One design question is whether we allow heterogeneous bound as in e.g. heterogeneous Multionmial distributions. Maybe an initial version could implement homogeneous bound, then later a heterogeneous bound.

@fritzo
Copy link
Member Author

fritzo commented Aug 16, 2020

We may want to separate Bint from Reals, then generalize Reals to Array with a .dtype property. Some reasons for separating Bint from Array[int] include:

  1. Numpy broadcasting semantics can behave differently for ints versus arrays
  2. Tuple getitem naturally inputs Bint but not arrays (indeed Bint can be seen as dual to Tuple)

@eb8680
Copy link
Member

eb8680 commented Jan 27, 2021

I'm going to close this as resolved by #417 and #356; if we need to implement specific patterns e.g. Reduce over nonscalar Bint domains for individual terms we can track them in separate issues.

@eb8680 eb8680 closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants