Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #322, #351 , #348
This unifies
BintType
andRealsType
types into a commonArrayType
with support for.dtype
and.shape
(I have unmarked those deprecated). After this PRBint[size, i,j,k]
denotes a homogeneously-boundedi x j x k
-sized array ofBint
. This PR does not yet use those integer valued arrays in distributions or elsewhere; that is for follow-up.This PR also clarifies the role of
Bint
. Whereas I had previously thought we would need heterogeneously-bounded distributions (as e.g. requested ofdist.Multinomial
), I now believe we can restrict to homogeneously-boundedBint
types, and add a separate heterogeneous typeTuple[Bint[2], Bint[3])
for indexing into arrays. This PR does not add thatTuple
, but it does clarify the planned type hierarchy:Tested