Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement log-time sequential sum product function #161

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Implement log-time sequential sum product function #161

merged 1 commit into from
Jul 17, 2019

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jul 17, 2019 •
edited
Loading

Addresses #70 #177
This ports Pyro's algorithm from pyro-ppl/pyro#1958 to funsor.
Pair coded with @eb8680

Tested

  • added tests with Tensor contraction.

Triaged

  • make a Slice funsor
  • implement Cat for Gaussians and Joints.

@fritzo fritzo requested a review from eb8680 July 17, 2019 02:13
@eb8680 eb8680 mentioned this pull request Jul 17, 2019
Open
5 tasks
@fritzo fritzo mentioned this pull request Jul 17, 2019
Merged
12 tasks
@eb8680 eb8680 mentioned this pull request Jul 17, 2019
Open
@eb8680 eb8680 merged commit b2e1169 into master Jul 17, 2019
@eb8680 eb8680 deleted the sequential-sum-product branch July 17, 2019 21:21
This was referenced Jul 24, 2019
Closed
Closed
@eb8680 eb8680 mentioned this pull request Oct 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb8680 eb8680 eb8680 approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @eb8680