Implement affine pattern recognition for Gaussian substitution #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
fehiepsi
reviewed
Oct 22, 2019
| assert issubclass(type(g_subs), GaussianMixture) | ||
| actual = g_subs(**grounding_subs) | ||
| expected = g(**ground_subs)(**grounding_subs) | ||
| assert_close(actual, expected, atol=1e-3, rtol=1e-4) |
There was a problem hiding this comment.
Finally, I can understand the purpose of each statement in this test. :D I will review the logic eager_subs_affine soon.
Merged
eb8680
reviewed
Oct 22, 2019
| new_offset = new_offsets[old_k] | ||
| new_slice = slice(new_offset, new_offset + old_size) | ||
| subs_matrix[..., new_slice, old_slice] = \ | ||
| torch.eye(old_size).expand(batch_shape + (-1, -1)) |
There was a problem hiding this comment.
This more advanced slicing isn't covered by existing BlockMatrix tests in test_gaussian.py, right? Would it make sense to add a couple of test cases there?
There was a problem hiding this comment.
This advanced indexing was already covered, but the particular sparse sequence of entries was not, so I added a test for that.
| g_subs = g(**subs) | ||
| assert issubclass(type(g_subs), GaussianMixture) | ||
| actual = g_subs(**grounding_subs) | ||
| expected = g(**ground_subs)(**grounding_subs) |
There was a problem hiding this comment.
This is a very satisfying test 🎉
fehiepsi
approved these changes
Oct 22, 2019
Let's hope this is the last time we'll ever need to write this code 😄 |
eb8680
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #72
Follows #284
This is step 2/3 in implementing affine recognition for Gaussian funsors. This PR:
Gaussian._eager_subs_affine()._find_gaps()to_find_intervals()for nonuniform block slicing inBlockVectorandBlockMatrix.Tested
BlockMatrix