Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TanhOp and AtanhOp #387

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Add TanhOp and AtanhOp #387

merged 3 commits into from
Oct 30, 2020

Conversation

eb8680
Copy link
Member

@eb8680 eb8680 commented Oct 29, 2020

Addresses #386

This PR adds two new TransformOps, tanh and atanh, which correspond to torch.distributions.transforms.TanhTransform and its inverse. It also upgrades ops.sigmoid to a TransformOp. These will be useful in testing transformed distributions.

Tested:

  • Added tanh and atanh to unary op tests in test_terms.py and test_tensor.py

@eb8680 eb8680 requested a review from fritzo October 29, 2020 20:40
This was referenced Oct 29, 2020
Open
Merged
@fritzo fritzo merged commit cf46731 into master Oct 30, 2020
@fritzo fritzo deleted the tanh-op branch October 30, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eb8680 @fritzo