Add Tuple funsor #430
Merged
Add Tuple funsor #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
eb8680
added
Blocked
fritzo
approved these changes
Jan 20, 2021
|
|
||
| class Product(tuple, metaclass=ProductDomain): | ||
| """like typing.Tuple, but works with issubclass""" | ||
| __args__ = NotImplemented |
There was a problem hiding this comment.
Does the __args__ name have something to do with the typing module? I would expect Python-builtin-style naming to correspond to some Python concept, and to use ._args otherwise.
There was a problem hiding this comment.
Yes, it's a convention I copied from typing whose purpose seems to be to signal that __args__ are to be accessed through a typing introspection API (e.g. typing_extensions.get_args(t)) rather than directly, perhaps because the internals of typing change a lot between releases. In a future PR we can add get_origin() and get_args() for Domains, as suggested in #351.
This was referenced Jan 20, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pair-coded with @fritzo. Addresses #351.