Unifying wrappers for distributions with logits/probs parametrization #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
approved these changes
May 9, 2019
|
So this is what you have in mind for your previous comment. Got it now! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @fritzo's suggestion in pyro-ppl/funsor#135, this creates light wrappers for all distributions with logits / probs parametrization. The advantage of this is that the underlying implementations are separate which makes them easy to test, simplifies code and removes any risk of accessing lazy parameters and triggering unnecessary computation. At the same time, the wrapper gives an identical interface to
torch.distributions.Testing: The wrappers are exercised in examples, the tests remain the same except for the renaming.