Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVI shared parameter initialization #1553

Merged
merged 2 commits into from
Mar 8, 2023
Merged

SVI shared parameter initialization #1553

merged 2 commits into from
Mar 8, 2023

Conversation

msegado
Copy link
Contributor

@msegado msegado commented Mar 8, 2023

Closes #1552

fehiepsi
fehiepsi approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice solution and tests!!! Thanks for the contribution, @msegado!

@msegado
Copy link
Contributor Author

msegado commented Mar 8, 2023

Very welcome - thanks for the great PPL 🙂

@fehiepsi fehiepsi merged commit 28d7f63 into pyro-ppl:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] SVI: avoid initializing model params when already specified in guide
2 participants
@msegado @fehiepsi