Allow users to specify total_count_max in Multinomial #1557

fehiepsi · 2023-03-19T12:29:34Z

Fixes #1556

martinjankowiak

lgtm but i wonder if these multinomial distributions need docstrings?

numpyro/distributions/discrete.py

martinjankowiak · 2023-03-26T14:47:05Z

some tests are failing are these just flaky?

test/infer/test_mcmc.py::test_beta_bernoulli_x64

fehiepsi added 3 commits March 19, 2023 08:26

allow users to specify total_count_max in Multinomial

1b9a744

black

f0c83ec

Merge remote-tracking branch 'upstream/master' into multinom

87fd2cd

fehiepsi added the awaiting review label Mar 20, 2023

fehiepsi requested a review from martinjankowiak March 20, 2023 13:42

martinjankowiak previously approved these changes Mar 20, 2023

View reviewed changes

add docstring for Multinomial

267f259

fehiepsi dismissed martinjankowiak’s stale review via 267f259 March 26, 2023 13:03

fehiepsi requested a review from martinjankowiak March 26, 2023 13:03

martinjankowiak previously approved these changes Mar 26, 2023

View reviewed changes

numpyro/distributions/discrete.py Outdated Show resolved Hide resolved

numpyro/distributions/discrete.py Outdated Show resolved Hide resolved

revise docstring of Multinomial

8efe57b

fehiepsi dismissed martinjankowiak’s stale review via 8efe57b March 26, 2023 13:16

martinjankowiak previously approved these changes Mar 26, 2023

View reviewed changes

skip flaky tests on CI

c3a1498

fehiepsi dismissed martinjankowiak’s stale review via c3a1498 March 26, 2023 16:33

martinjankowiak approved these changes Mar 26, 2023

View reviewed changes

martinjankowiak merged commit fa5ce64 into pyro-ppl:master Mar 26, 2023

Provide feedback