Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make possible to fix the number of LF steps and tune the step size #1698

Merged
merged 6 commits into from
Dec 17, 2023
Merged

Make possible to fix the number of LF steps and tune the step size #1698

merged 6 commits into from
Dec 17, 2023

Conversation

yayami3
Copy link
Contributor

@yayami3 yayami3 commented Dec 15, 2023

Closes #1678

@yayami3
Copy link
Contributor Author

yayami3 commented Dec 15, 2023

How to fix error below at action.

To use this module, please install jaxns package. It can be installed with pip install jaxns with python>=3.8

@fehiepsi
Copy link
Member

I guess the latest working version is jaxns=2.2.6. Could you limit the version here and here

@fehiepsi
Copy link
Member

Thanks, @yayami3! Could you add a simple test for this?

@yayami3
Copy link
Contributor Author

yayami3 commented Dec 16, 2023

test added.

@fehiepsi
pls review!

fehiepsi
fehiepsi approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great!! thanks @yayami3!

@fehiepsi fehiepsi merged commit c914c53 into pyro-ppl:master Dec 17, 2023
4 checks passed
@yayami3 yayami3 deleted the update_adaptation_hmc branch December 30, 2023 03:10
OlaRonning pushed a commit to aleatory-science/numpyro that referenced this pull request May 6, 2024
@yayami3 @OlaRonning
Make possible to fix the number of LF steps and tune the step size (p…
84469bf 
…yro-ppl#1698)

* make possible to fix the number of LF steps per sample and tune the step size

* fix typo

* fix version jaxns==2.2.6

* warn only when called from HMC

* add test

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zero HMC acceptance rate for standard normal
2 participants
@yayami3 @fehiepsi