Fixes random_flax_module with flax.linen.BatchNorm
#1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanitorduz
commented
Jun 30, 2024
Comment on lines
+310
to
+313
| # test svi | ||
| guide = AutoDelta(model) | ||
| svi = SVI(model, guide, numpyro.optim.Adam(0.01), Trace_ELBO()) | ||
| svi.run(random.PRNGKey(100), 10) |
There was a problem hiding this comment.
Without these SVI lines, the tests were passing in the master branch. Once added, we got the error. The suggested fix in the issue does solve it.
|
The first two commits are from an old branch 🤦 . We can squash and merge instead. |
fehiepsi
reviewed
Jun 30, 2024
fehiepsi
reviewed
Jul 1, 2024
fehiepsi
reviewed
Jul 1, 2024
|
|
|
@fehiepsi should I leave |
|
Leaving it in Thanks for fixing the issue! |
fehiepsi
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1446