-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constraints for multiple intervals #1829
Conversation
Hi @Qazalbash, do you have any concrete example of those constraints? |
forward_shape=constraint.lower_bounds.shape, | ||
inverse_shape=(constraint.lower_bounds.size,), | ||
), | ||
ExpTransform(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this composed transform is bijective. Could you clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote this code snippet to test the constraints of the system. This was the best example I could come up with based on a quick review of the test cases. Please note that this code is not based on any specific logic, so feel free to correct me if I'm wrong or suggest improvements!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Probably the tests pass because the domain is quite loose. Exp transform has positive codomain, not union of intervals.
For the union of intervals, an example. I now realize we can avoid the intersection of intervals to a single interval. For the unique interval case, I was writing transformation defined as, where, and turns out the bounds for each are, I had to deal with a similar situation where each element in the |
For the unique interval case, you can use |
I got your point. I still don't get |
In that example, I guess you can use the constraint
|
Thank you! |
I have implemented three different constraints that involve multiple closed intervals.