Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using legacy constructors Tensor.new in contrib.gp #1844

Closed
wants to merge 1 commit into from

Conversation

fehiepsi
Copy link
Member

@fehiepsi fehiepsi commented May 1, 2019

Follow up of #1842. This is ready to review if tests pass.

@fehiepsi
Copy link
Member Author

fehiepsi commented May 2, 2019

It seems that Travis is unstable...

@fritzo
Copy link
Member

fritzo commented May 2, 2019

@fehiepsi it appears there was some confusion on the PyTorch side and these are no longer considered legacy constructors pytorch/pytorch#19995 If pyro.contrib.gp does not currently support the jit, then there is no immediate need to avoid these constructors.

I think it's safe to close this PR.

@fehiepsi fehiepsi closed this May 2, 2019
@fehiepsi
Copy link
Member Author

fehiepsi commented May 2, 2019

Actually, I just run the benchmark test with jit loss_fn and get the error RuntimeError: Cannot insert a Tensor that requires grad as a constant. Consider making it a parameter or input, or detaching the gradient Tensor: (might be related to this issue). I am not sure what I should do to resolve it right now so jitted contrib.gp might not be supported in the near future. cc @neerajprad

@neerajprad
Copy link
Member

@fehiepsi - Please don't worry about it. This is just a minor release to make Pyro compatible with the latest PyTorch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants