Adding Mean Field LDA draft example (yields bad results) #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Remove docs with zero length (2 occurrences) and pad docs with 0 index | ||
| docs = [doc for doc in docs if len(doc) > 0] | ||
| docs = pad_sequence(docs, batch_first=True, padding_value=0) |
There was a problem hiding this comment.
are you sure that padding each document with zeros is a good idea? doesn't that affect the performance of the model?
There was a problem hiding this comment.
@slayeren this implementation uses dense tensors and Pyro's automatic enumeration to integrate out zeta and is indeed quite slow (hence the title :) ). See the ProdLDA tutorial for a less naive approach to topic modeling in Pyro.
Please use our forum for any followup questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
As requested in the forum, I'm opening a draft PR with the buggy Mean Field LDA code. Glad to talk if comments!
Cheers!
Carlos