Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mypy to pre-commit - #639 #640

Closed
wants to merge 6 commits into from

Conversation

jGaboardi
Copy link
Member

This PR resolves #639

@jGaboardi jGaboardi self-assigned this Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (4037c70) to head (559e35d).
Report is 88 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #640     +/-   ##
=======================================
+ Coverage   97.4%   98.1%   +0.8%     
=======================================
  Files         26      38     +12     
  Lines       4328    6203   +1875     
=======================================
+ Hits        4214    6088   +1874     
- Misses       114     115      +1     

@martinfleis
Copy link
Member

I am not sure I am fan of this... Linting is easy to fix, typing may be harder. And if you have pre-commit hook installed locally, this won't allow you to commit and push to ask in the PR what the typing should be.

@jGaboardi jGaboardi deleted the GH639_mypy_precommit branch July 11, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy - move from action to pre-commit
2 participants